[Dashboard] Unskip failing embed_mode screenshot test
#163424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heenawter
added
Team:Presentation
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @Heenawter |
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
bryce-b
pushed a commit
to bryce-b/kibana
that referenced
this pull request
Aug 9, 2023
Closes elastic#163207 ## Summary Since Chrome was updated in the CI environment, our old CI-generated screenshots were outdated - this PR updates the `embed_mode` screenshot tests so that we are once again in sync with the CI environment. For more context, please refer to elastic#160085 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #163207
Summary
Since Chrome was updated in the CI environment, our old CI-generated screenshots were outdated - this PR updates the
embed_modescreenshot tests so that we are once again in sync with the CI environment.For more context, please refer to #160085
Checklist
For maintainers